Go offline with the Player FM app!
Finding a code-review style that fits your brain
Manage episode 495267585 series 2974897
Joel and Aaron compare two very different ways to tackle pull-requests—reviewing them commit-by-commit or scanning the whole thing at once. They dig into when each approach shines, how “atomic” commits can help (or hurt) reviewers, and why understanding how your teammate’s brain works is a super-power. Along the way they share practical tips for leaving yourself notes, spotting hidden changes, and keeping large refactors under control.
- (00:00) - The “gift” of a pull request and the pain of huge PRs
- (02:30) - Joel’s commit-by-commit strategy and where it helps
- (04:50) - Aaron’s Tetris-style holistic review (and leaving self-notes)
- (07:45) - When atomic commits backfire and trust becomes a factor
- (08:45) - Silly bit
Sign up for the newsletter
131 episodes
Manage episode 495267585 series 2974897
Joel and Aaron compare two very different ways to tackle pull-requests—reviewing them commit-by-commit or scanning the whole thing at once. They dig into when each approach shines, how “atomic” commits can help (or hurt) reviewers, and why understanding how your teammate’s brain works is a super-power. Along the way they share practical tips for leaving yourself notes, spotting hidden changes, and keeping large refactors under control.
- (00:00) - The “gift” of a pull request and the pain of huge PRs
- (02:30) - Joel’s commit-by-commit strategy and where it helps
- (04:50) - Aaron’s Tetris-style holistic review (and leaving self-notes)
- (07:45) - When atomic commits backfire and trust becomes a factor
- (08:45) - Silly bit
Sign up for the newsletter
131 episodes
All episodes
×Welcome to Player FM!
Player FM is scanning the web for high-quality podcasts for you to enjoy right now. It's the best podcast app and works on Android, iPhone, and the web. Signup to sync subscriptions across devices.